Jump to content


Photo

Parenthesis do not work correctly in Hebrew searches.


  • Please log in to reply
9 replies to this topic

#1 miketisdell

miketisdell

    Gold

  • Active Members
  • PipPipPipPip
  • 359 posts
  • Accordance Version:12.x
  • Platforms:Windows, Android

Posted 08 May 2018 - 10:37 PM

I reported this in a reply in the other thread, but I am not sure if was seen so I am reporting it again in its own thread. I just checked 1.1.0b22(9784) and it still doesn't work.

 

 

Parenthesis do not work correctly in Hebrew searches.

 

Example: ‏איש ‎<AND> ‏(אמר ‎<AND>‏ אלהים)

 

On the computer this search works, but on the tablet it does not.

I get the following message that appears and then disappears rather quickly: "An unexpected parenthesis was encountered.\n\n Each close parenthesis must be preceded by a corresponding open parenthesis."

 

In English the parenthesis work without a problem.



#2 Scott M

Scott M

    Platinum

  • Accordance
  • 536 posts
  • Gender:Male
  • Accordance Version:10.x

Posted 09 May 2018 - 01:40 PM

Thanks for the reminder. It's on my list. I wanted to make sure that the glossing issues (VULG-T, etc.) was fixed and pushed that out without catching up the remaining issues. Which I'll be attacking next.


  • miketisdell likes this

#3 Scott M

Scott M

    Platinum

  • Accordance
  • 536 posts
  • Gender:Male
  • Accordance Version:10.x

Posted 10 May 2018 - 10:59 AM

OK, so ostensibly, this is 'fixed.' But to do so, I had to remove a long-standing function with the name:

 

ReverseHebrewParentheses

 

which makes me a bit nervous. Further, as I attempted (fumbled) to enter the search terms in the OP, this odd behavior (seems that way to me, anyways) showed up:

 

 

9ljsrb.jpg

 

When I used the Android Hebrew keyboard, and tapped their '(', the text box got an ')'. (The red arrows.) And vice versa (blue arrows). So something is going on here. And I believe if a user dutifully tapped their '(' and ')' on the Hebrew keyboard and left them unmolested in their reversed (by the Android Hebrew keyboard) state, then the reversal operation Accordance has long performed would behave. But if the user 'corrects' the reversal of the Hebrew keyboard entry, by reversing the reversal, then Accordance would reverse the reversed reversal and the search would fail.

 

All the while, I begin to accumulate a headache.

 

So in theory, this problem is 'fixed', if the standard is to make correct looking (reversed reversal) parens search properly. But it sorta feels like a potential morass to me where XX% of people are going to do it one way that 'fails' and XX% the other. Open to thoughts on this point...



#4 Helen Brown

Helen Brown

    Emerald

  • Admin
  • 11,658 posts
  • Twitter:accordancebible
  • Gender:Female
  • Location:heart in Israel
  • Accordance Version:12.x
  • Platforms:Mac OS X, Windows, iOS, Android

Posted 10 May 2018 - 12:12 PM

We think that the text in the Entry needs to look correct, even if to achieve that the user needs to tap the "wrong" keys to achieve it.


  • Scott M likes this
Helen Brown
OakTree Software

#5 Scott M

Scott M

    Platinum

  • Accordance
  • 536 posts
  • Gender:Male
  • Accordance Version:10.x

Posted 10 May 2018 - 12:34 PM

We think that the text in the Entry needs to look correct, even if to achieve that the user needs to tap the "wrong" keys to achieve it.

 

OK, then I'll leave in the fix for the next release. Thanks.



#6 דָנִיאֶל

דָנִיאֶל

    Ruby

  • Super Member
  • PipPipPipPipPipPipPip
  • 5,377 posts
  • Gender:Male
  • Accordance Version:12.x
  • Platforms:Mac OS X, Windows, Android

Posted 10 May 2018 - 12:43 PM

I had hoped that Unicode defined open and close for the various bracket types and then the direction would be chosen appropriately to context. However I was just looking again at this and it seems that brackets are considered to be neutral and Unicode defines code points for left and right not open and close. I then realized that there are ( I think there are anyway ) cases in bidi text situations where I don't think the code can do it properly without help from the user alas.

 

So in short I'm not sure the user can be oblivious and magically the right thing gets done. I should read more on it one day when I have a large cup of coffee and nothing else to do. :)

 

I'll try it out when it appears and I'll test it with my Android keyboard too - not that it is necessarily correct :)

 

Thx

D


  • Scott M likes this

Sola lingua bona est lingua mortua
ἡ μόνη ἀγαθὴ γλῶσσα γλῶσσα νεκρὰ ἐστιν
lišanu ēdēnitu damqitu lišanu mītu

"Du stammst vom Herrn Adam und der Herrin Eva ab", sagte Aslan. "Und das ist zugleich Ehre genug, um das Häupt des ärmsten Bettlers zu erheben, und genug, um die Schultern des größten Kaisers auf Erden zu beugen. Sei zufrieden." Aslan, Die Chroniken von Narnia, Prinz Kaspian von Narnia. CS Lewis. Übersetzt von Wolfgang Holbein und Christian Rendel.

Accordance Syntax Search For Wallace's Greek Grammar Beyond the Basics : https://github.com/4...WallaceInSyntax

 

Accordance Crib Sheets: http://47rooks.com/l...ch-crib-sheets/

 

 

Accordance Configurations :

Mac : 2009 27" iMac
12GB RAM

Windows : MSI GE72 7RE Apache Pro laptop
Intel Core Duo Intel i7 Kabylake

Android : Samsung Note III 5.0, Samsung Tab S3 7.0 and Lenovo TAB4 8" 7.1


#7 miketisdell

miketisdell

    Gold

  • Active Members
  • PipPipPipPip
  • 359 posts
  • Accordance Version:12.x
  • Platforms:Windows, Android

Posted 10 May 2018 - 01:07 PM

OK, so ostensibly, this is 'fixed.' But to do so, I had to remove a long-standing function with the name:

 

ReverseHebrewParentheses

 

which makes me a bit nervous. Further, as I attempted (fumbled) to enter the search terms in the OP, this odd behavior (seems that way to me, anyways) showed up:

 

 

9ljsrb.jpg

 

When I used the Android Hebrew keyboard, and tapped their '(', the text box got an ')'. (The red arrows.) And vice versa (blue arrows). So something is going on here. And I believe if a user dutifully tapped their '(' and ')' on the Hebrew keyboard and left them unmolested in their reversed (by the Android Hebrew keyboard) state, then the reversal operation Accordance has long performed would behave. But if the user 'corrects' the reversal of the Hebrew keyboard entry, by reversing the reversal, then Accordance would reverse the reversed reversal and the search would fail.

 

All the while, I begin to accumulate a headache.

 

So in theory, this problem is 'fixed', if the standard is to make correct looking (reversed reversal) parens search properly. But it sorta feels like a potential morass to me where XX% of people are going to do it one way that 'fails' and XX% the other. Open to thoughts on this point...

 

 

Question: Are you using the Hebrew keyboard on your Android device? When I type on my keyboard, I get the correct parentheses on the Android display (Samsung Galaxy 7 & Samsung Tab2 10")



#8 Scott M

Scott M

    Platinum

  • Accordance
  • 536 posts
  • Gender:Male
  • Accordance Version:10.x

Posted 10 May 2018 - 01:12 PM

Question: Are you using the Hebrew keyboard on your Android device? When I type on my keyboard, I get the correct parentheses on the Android display (Samsung Galaxy 7 & Samsung Tab2 10")

 

Yes, I'm using the Hebrew keyboard on the Android device. That's what I show in the screen shot. That's on my device, hard to say if it is entirely uniform across Android versions.



#9 miketisdell

miketisdell

    Gold

  • Active Members
  • PipPipPipPip
  • 359 posts
  • Accordance Version:12.x
  • Platforms:Windows, Android

Posted 10 May 2018 - 01:19 PM

Yes, I'm using the Hebrew keyboard on the Android device. That's what I show in the screen shot. That's on my device, hard to say if it is entirely uniform across Android versions.

 

I just tried it again, and I get the backwards parenthesis (like in you example) if I begin with a parenthesis (it starts out correct but left aligned, and then changes to right aligned and backwards when I press the first Hebrew letter). If I begin with a Hebrew word and then type a parenthesis, it appears correct on the display.

 

NOTE: I can also type the first Hebrew word and then go back and add the parenthesis and it looks correct.


Edited by miketisdell, 10 May 2018 - 01:20 PM.


#10 miketisdell

miketisdell

    Gold

  • Active Members
  • PipPipPipPip
  • 359 posts
  • Accordance Version:12.x
  • Platforms:Windows, Android

Posted 11 May 2018 - 11:47 AM

I just tried the attached search this morning in 1.1.0b23 and it WORKS!

And it displays correctly too.Attached File  Screenshot_20180511-094826.png   495.32KB   0 downloads

Edited by miketisdell, 11 May 2018 - 11:48 AM.

  • Scott M likes this




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users